search

mampfes / esphome_obis_d0

esphome external component to support meters with OBIS D0 interface
MIT License
45 stars 6 forks source link

Upstreaming it? #17

Open yoshimo opened 10 months ago

yoshimo commented 10 months ago

Have you considered making this part of ESPHome itself and create a pull request like the Optolink Team does in https://github.com/esphome/esphome/pull/4453 ?

mampfes commented 9 months ago

From my experience, it creates a lot of extra effort to merge a component into esphome (or HomeAssistant) main branch and then maintain it there. Therefore I don't have plans to do this at the moment.

yoshimo commented 9 months ago

Would be nice to at least get feedback and then decide if it's worth the time right now.

yoshimo commented 9 months ago

https://esphome.io/components/sml.html is offered upstream, does this differ significantly?

mampfes commented 9 months ago

SML and D0 are 2 different communication protocols, but both use OBIS codes.

yoshimo commented 9 months ago

ah ok, so not synonym and still needed to become mainlined.