mampfes / hacs_waste_collection_schedule

Home Assistant integration framework for (garbage collection) schedules
MIT License
1.08k stars 658 forks source link

[Bug]: abfall_lippe_de source stopped working (for ICS files for 2024) #1568

Closed alexanderbeermann closed 10 months ago

alexanderbeermann commented 10 months ago

I Have A Problem With:

A specific source

What's Your Problem

Hey guys,

The source abfall_lippe_de stopped working. For 2023 it was working fine - for 2024 it stopped working. So, right now all my sensors display "unknown" since there is no data.

I just visited the site, they changed the way to download the ICS, i guess that's why the integration isn't able to fetch any data.

Unfortunately I do not see any hints within the logs:

I already figured out, that they changed the URL structure for the ics files: - they switched the position of "year" and "bezirk"

2023: https://abfall-lippe.de/wp-content/uploads/2022/12/Bad_Salzuflen_AA_2023.ics 2024: https://abfall-lippe.de/wp-content/uploads/2023/12/Bad-Salzuflen-2024_AA.ics

Source (if relevant)

No response

Logs

no log entry - I assume WCS is still finding the ics files for 2023 and thus no exception is raised.

Relevant Configuration

waste_collection_schedule:
  sources:
    - name: abfall_lippe_de
      args:
        gemeinde: Bad Salzuflen
        bezirk: AA

Checklist Source Error

Checklist Sensor Error

Required

5ila5 commented 10 months ago

It's not really a big bug. The current source tries to fetch the current year first. if this does fail it tries to fetch different years. This source will return valid 2024 entries beginning from the 1st January 2024. It does not fetch the ICS file URL directly but gets the ics urls from the overview html.

But I made some changes in #1570 which will be part of the 1.45.0 release which will try to fetch the next year in December as well.

Fix will be part of release 1.45.0 or is available now as master (git) version (HACS: 3-dot menu -> redownload -> change version to master)