search

mampfes / hacs_waste_collection_schedule

Home Assistant integration framework for (garbage collection) schedules
MIT License
1k stars 634 forks source link

[Feature]: Validation action for all PRs #2358

Open bratanon opened 1 month ago

bratanon commented 1 month ago

I propose a feature for:

The integration in general

Describe your wanted feature

To ensure the integrity of our codebase, we occasionally encounter test failures and broken installations due to faulty code being merged into the main branch.

I propose implementing a GitHub Action that runs on all pull requests to validate them. This action would execute all source/service tests to ensure they pass before the code is merged. Additionally, we could set up an automated installation in HA to verify the build. Given the resource intensity of the latter, it might be more efficient to schedule it to run once daily.

This approach would help maintain code quality and reduce disruptions from faulty merges.

5ila5 commented 1 month ago

Yes i'd agree testing the source is not really the problem.

But running the pre-commit hooks and running the update_docu_links.py script would probably be a good idea, I think it's not even that hard. I may look into this in the near future