Tips: consider standardizing the data attributes - Githubissues

mamunhpath / josh.js

A JavaScript library to animate content on page scroll.

https://mamunhpath.github.io/josh.js/

MIT License

409 stars 19 forks source link

Tips: consider standardizing the data attributes #15

Open hidegh opened 1 year ago

hidegh commented 1 year ago

data-josh-anim-name="lightSpeedInRight" data-josh-duration="1500ms" data-josh-anim-delay="3.5s" data-josh-iteration="infinite"

isnt the duration and iteration related to anim?
the why don't we use data-josh-anim- prefix?
or why even use data-josh-anim- and not just data-josh- since the library itself is around animation ❓

as this is a breaking change, advising:

updating major version and use just data-josh-delay, etc. names
updating readme and leave a note on this there