mamuz / PhpDependencyAnalysis

Static code analysis to find violations in a dependency graph
http://mamuz.github.io/PhpDependencyAnalysis/
MIT License
564 stars 45 forks source link

Bug "Invalid configuration setting: verbose" #14

Closed fonsecas72 closed 8 years ago

fonsecas72 commented 8 years ago

Hi, I have introduced a bug in your library. When you call the analyze command in verbose mode, e.g. "bin/phpda analyze phpda.yml.dist -v" The following exception is throw

  [InvalidArgumentException]              
  Invalid configuration setting: verbose 

This happens because we are passing all the input to the Config class. Before trying to fix it I wanted to know what do you think.

mamuz commented 8 years ago

I suggest to remove the implementation of PR11.

The effort to fix this issue compared to the value of PR11 is to high.

I also think that would make it more future proof.

fonsecas72 commented 8 years ago

I agree. Also: I think we should definitely protect our selves from this issue in the future.