search

man-group / ArcticDB

ArcticDB is a high performance, serverless DataFrame database built for the Python Data Science ecosystem.
http://arcticdb.io
Other
1.23k stars 79 forks source link

Useful error message when empty string provided as symbol name #1612

Closed alexowens90 closed 3 weeks ago

alexowens90 commented 3 weeks ago

Currently get logs like:

ASSERTION FAILURE: Empty string id in reference key
Loading versions from storage via ref key failed with error: Empty string id in reference key for stream . Retrying
ASSERTION FAILURE: Empty string id in reference key
Loading versions from storage via ref key failed with error: Empty string id in reference key for stream . Retrying

but the actual exception thrown is ASSERTION FAILURE: Couldn't read via ref key even after multiple attempts, which does not show the underlying cause.

Should just involve checking for empty strings in verify_name in name_validation.cpp, but need to carefully check that this will not break any other use cases of this function.