NO_SUCH_BUCKET and RESOURCE_UNAVAILABLE are not expected error types

man-group / ArcticDB

ArcticDB is a high performance, serverless DataFrame database built for the Python Data Science ecosystem.

http://arcticdb.io

Other

1.46k stars 93 forks source link

NO_SUCH_BUCKET and RESOURCE_UNAVAILABLE are not expected error types #1648

Open willdealtry opened 3 months ago

willdealtry commented 3 months ago

We should not treat resource unavailable or no such bucket as expected S3 errors, as we might incorrectly decide that an object doesn't exist and can be newly created when in fact we've just not managed to talk to the storage to ascertain whether it's there or not.

muhammadhamzasajjad commented 3 months ago

We shouldn't remove RESOURCE_NOT_FOUND. As mentioned in this issue, RESOURCE_NOT_FOUND is returned when you call HeadObject() and the key is not found. You can also see this in failing tests in the CI. This came up during my exception normalization PRs (I guess I should've left a comment explaining why RESOURCE_NOT_FOUND is swallowed).

As for NO_SUCH_BUCKET, it is kept as per what is found here. Although, we might be able remove this with some more work.