man-group / ArcticDB

ArcticDB is a high performance, serverless DataFrame database built for the Python Data Science ecosystem.
http://arcticdb.io
Other
1.46k stars 93 forks source link

Sum aggregations can needlessly overflow #1786

Closed alexowens90 closed 1 month ago

alexowens90 commented 1 month ago

Type promotion rules only took into account types that could represent all input columns, but the some of such a type could be larger.

Fix is to use the widest type of the 3 numeric flavours (unsigned int, signed int, float) for the output column.