search

man-group / ArcticDB

ArcticDB is a high performance, serverless DataFrame database built for the Python Data Science ecosystem.
http://arcticdb.io
Other
1.52k stars 93 forks source link

Run the pull request on the PR sha with the pull_request_target event #1954

Closed maxim-morozov closed 3 weeks ago

maxim-morozov commented 3 weeks ago

Reference Issues/PRs

What does this implement or fix?

Any other comments?

Checklist

Checklist for code changes... - [ ] Have you updated the relevant docstrings, documentation and copyright notice? - [ ] Is this contribution tested against [all ArcticDB's features](../docs/mkdocs/docs/technical/contributing.md)? - [ ] Do all exceptions introduced raise appropriate [error messages](https://docs.arcticdb.io/error_messages/)? - [ ] Are API changes highlighted in the PR description? - [ ] Is the PR labelled as enhancement or bug so it appears in autogenerated release notes?
maxim-morozov commented 3 weeks ago

How does this work while we still only have:

on:
  pull_request:

?

Could you share some test evidence?

It was reverted by the merge. But take a look now, it has pull_request_target