man-group / ArcticDB

ArcticDB is a high performance, serverless DataFrame database built for the Python Data Science ecosystem.
http://arcticdb.io
Other
1.51k stars 93 forks source link

Fix persistent storage test #1997

Open phoebusm opened 1 week ago

phoebusm commented 1 week ago
  1. storage_test.py verify action doesn't support checking libraries with v2 API https://github.com/man-group/ArcticDB/blob/e76e9404d32ed04cfe4c07a83378e72641924d49/python/tests/util/storage_test.py#L302
    • While test_real_s3_storage_write test v2 API
  2. Persistent storage test has not been scheduled or triggerd automatically
    • It should be run on master branch whenever there is PR merge IMO

And may be I am wrong but seed_library in storage_test.py are created but no used?

phoebusm commented 1 week ago

Depended by https://github.com/man-group/ArcticDB/issues/1230