man-group / ArcticDB

ArcticDB is a high performance, serverless DataFrame database built for the Python Data Science ecosystem.
http://arcticdb.io
Other
1.25k stars 79 forks source link

Promote internal API method `clear` to python API #375

Open phoebusm opened 1 year ago

phoebusm commented 1 year ago

Internal API method lib.version_store.clear() is frequently used. Given how frequently it's used, we should promote it to a top-level method.

The method deletes everything inside a library.

willdealtry commented 1 year ago

I'm not sure we really want to encourage people to do this any more than they already do.

mehertz commented 1 year ago

It's a reasonable API call IMO. What's the alternative?

jamesmunro commented 2 weeks ago

delete_library calls _nvs.version_store.clear() and is IMO better named. https://github.com/man-group/ArcticDB/blob/8cf8279b45649f03582202e169aeb6a0f2978732/python/arcticdb/arctic.py#L219 Is there a strong use case for clear without removing the library config?