search

man-group / arctic

High performance datastore for time series and tick data
https://arctic.readthedocs.io/en/latest/
GNU Lesser General Public License v2.1
3.06k stars 583 forks source link

python 3.6/3.7 circleCI all tests passing. #925

Closed dunckerr closed 2 years ago

dunckerr commented 3 years ago

circleci build is now working for python 3.6 and 3.7 python 2.7 build is disabled but still available in circleci.yml if required python 3.6/3.7 dataframe index sort order changes meant we have to add sort_index(axis=1) to assert_frame_equal

dunckerr commented 2 years ago

@bmoscon @eeaston @shashank88 I have removed python 2.7 build and got all the tests working for python 3.6/3.7 with pandas pinned to 1.0.3. I've introduced a shim tests/util/assert_frameequal which calls assert_frame_equal but with the dataframe columns sorted alphabetically. I've only made this change on failing tests. where the test is passing we still call assert_frame_equal directly. Can you review please?

I also had a look at running the tests with pandas 1.1.5. This has a similar dataframe comparison change in assert_frame_equal which could be fixed by ignoring the dataframe "freq" flag with checkfreq=False. This work isn't finished (still some broken tests) but you can see the code is included in the assert_frameequal shim for future use.

bmoscon commented 2 years ago

@dunckerr nice work! I remember when this library only supported 2.7 and @TomTaylorLondon and I got it ported to py3 and working over a winter vacation. Nice to see 2.7 being left in the dust!

dunckerr commented 2 years ago

Hi Bryant - thanks. Im a bit nervous about changing the tests, but I can't see any other way of handling the change in ordering of data frame columns.

I presume you guys got it working with python 3 and pandas 0.22.0?

BTW I've working on another change to fix pathologically slow calls to mongo_count, and then I plan on releasing 1.80.1. I'll let you know. Cheers Duncan

On Nov 29, 2021, at 11:44 AM, Bryant Moscon @.***> wrote:



@dunckerrhttps://github.com/dunckerr nice work! I remember when this library only supported 2.7 and @TomTaylorLondonhttps://github.com/TomTaylorLondon and I got it ported to py3 and working over a winter vacation. Nice to see 2.7 being left in the dust!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHubhttps://github.com/man-group/arctic/pull/925#issuecomment-981558122, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA7RFWZGRMZP2FMYITHAESLUONRSNANCNFSM5IZKN4WA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.