search

man-group / arctic

High performance datastore for time series and tick data
https://arctic.readthedocs.io/en/latest/
GNU Lesser General Public License v2.1
3.06k stars 583 forks source link

Blackify the code #957

Closed vietlq closed 2 years ago

vietlq commented 2 years ago

Probably run with our favourite command:

black -l 120
dunckerr commented 2 years ago

I think the consensus is that running black would just make life complicated when diffing the codebase. Let’s leave it commented out in .circleci yaml.

On Feb 20, 2022, at 9:14 AM, Viet @.***> wrote:



Probably run with our favourite command:

black -l 120

— Reply to this email directly, view it on GitHubhttps://github.com/man-group/arctic/issues/957, or unsubscribehttps://github.com/notifications/unsubscribe-auth/AA7RFW4EWL2QE6CJJ6TYMWDU4CWHDANCNFSM5O4E3GLA. Triage notifications on the go with GitHub Mobile for iOShttps://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Androidhttps://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub. You are receiving this because you are subscribed to this thread.Message ID: @.***>

bmoscon commented 2 years ago

yes - it will massively pollute the git blame changespace for minimal gain (if any).

dunckerr commented 2 years ago

closing