search

man-group / arctic

High performance datastore for time series and tick data
https://arctic.readthedocs.io/en/latest/
GNU Lesser General Public License v2.1
3.04k stars 583 forks source link

When serializing DateTimeIndex, cast .tz property to str instead of u… #990

Closed chazkii closed 1 year ago

chazkii commented 1 year ago

…sing pandas tslib get_timezone

chazkii commented 1 year ago

Raising new PR with merge into master

chazkii commented 1 year ago

@dunckerr good point - I looked through the commit history and use of get_timezone was in the very first commit in 2015, meaning initial introduction maybe even older given Arctic was worked on internally.

I've looked at the implementation of get_timezone and to make things safer, I will only cast to string if it isn't a string already.