search

man-group / dapr-sidekick-dotnet

Dapr Sidekick for .NET - a lightweight lifetime management component for Dapr
Apache License 2.0
175 stars 21 forks source link

Return correct health status when attached #15

Closed badgeratu closed 3 years ago

badgeratu commented 3 years ago

Description

If process status is Attached then health check is now correctly carried out against the attached sidecar.

Issue reference

Fixes Issue #7

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-commenter commented 3 years ago

Codecov Report

Merging #15 (ae73da0) into main (56d7385) will decrease coverage by 0.03%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #15      +/-   ##
==========================================
- Coverage   88.90%   88.86%   -0.04%     
==========================================
  Files         104      104              
  Lines        2236     2237       +1     
  Branches      453      453              
==========================================
  Hits         1988     1988              
  Misses        159      159              
- Partials       89       90       +1
Flag Coverage Δ
net35 85.38% <100.00%> (-0.06%) :arrow_down:
net48 86.63% <100.00%> (-0.11%) :arrow_down:
net5.0 88.23% <100.00%> (-0.05%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...Dapr.Sidekick.AspNetCore/DaprProcessHealthCheck.cs 92.85% <100.00%> (ø)
src/Man.Dapr.Sidekick/Process/DaprProcessInfo.cs 95.00% <100.00%> (-5.00%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 56d7385...ae73da0. Read the comment docs.