search

man-group / dapr-sidekick-dotnet

Dapr Sidekick for .NET - a lightweight lifetime management component for Dapr
Apache License 2.0
175 stars 21 forks source link

Use "DaprSidekick" config section in preference to "Dapr" #16

Closed badgeratu closed 3 years ago

badgeratu commented 3 years ago

Description

Configuration settings will now be read in preference from a "DaprSidekick" section, and fallback to the original "Dapr" section if it does not exist.

Issue reference

Closes #8

Please reference the issue this PR will close: #[issue number]

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-commenter commented 3 years ago

Codecov Report

Merging #16 (953fe17) into main (29db227) will decrease coverage by 0.07%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #16      +/-   ##
==========================================
- Coverage   88.86%   88.79%   -0.08%     
==========================================
  Files         104      104              
  Lines        2237     2240       +3     
  Branches      453      455       +2     
==========================================
+ Hits         1988     1989       +1     
- Misses        159      160       +1     
- Partials       90       91       +1
Flag Coverage Δ
net35 85.38% <ø> (ø)
net48 86.69% <ø> (ø)
net5.0 88.15% <100.00%> (-0.08%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Man.Dapr.Sidekick/Options/DaprOptions.cs 100.00% <ø> (ø)
...NetCore/DaprSidekickServiceCollectionExtensions.cs 92.10% <100.00%> (-5.04%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 29db227...953fe17. Read the comment docs.