man-group / dapr-sidekick-dotnet

Dapr Sidekick for .NET - a lightweight lifetime management component for Dapr
Apache License 2.0
175 stars 21 forks source link

Namespace environment variable not set #28

Closed helmerm closed 2 years ago

helmerm commented 2 years ago

Expected Behavior

Namespace environment variable set on daprd process.

Actual Behavior

Namespace variable not set (verified with ProcessExplorer). DAPR_* variables are set.

Steps to Reproduce the Problem

CLI version: 1.4.0 Runtime version: 1.3.0 Man.Dapr.Sidekick 1.1.0 Windows 10

pubsub.yml

apiVersion: dapr.io/v1alpha1 kind: Component metadata: name: mqtt-pubsub namespace: remote spec: type: pubsub.mqtt version: v1 metadata:

appsettings.json "DaprSidekick": { "Sidecar": { "Namespace": "local" } }

Release Note

RELEASE NOTE: FIX Missing Namespace environment variable.

badgeratu commented 2 years ago

This is an interesting one - I think we've not come across it because we use mTLS encryption and when that is enabled in Sidekick (i.e. mTLS: "true" in appsettings.json) the NAMESPACE environment variable is set with either a default value of default or the value defined through configuration. You can see the predicate check here. We'll take a look shortly and see how best to fix it, shouldn't take too long.

And thanks for your interest in Sidekick!

helmerm commented 2 years ago

Thank you!

badgeratu commented 2 years ago

Now available in Release v1.2