Closed badgeratu closed 2 years ago
:warning: Please install the to ensure uploads and comments are reliably processed by Codecov.
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 88.98%. Comparing base (
eda4078
) to head (00021ec
). Report is 6 commits behind head on main.
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Description
This PR fixes Issue #28 where the NAMESPACE environment variable was only set when mTLS was enabled. It also introduces a new feature for setting custom environment variables through configuration, overriding any environment variables that would have been set based on other configuration values. The new
EnvironmentVariables
property is available at any of the process options levels in configuration, for example:This configuration setting will write out the environment variables
MYVAR=OVERRIDE_VALUE
andNAMESPACE=CUSTOM_VALUE
- so the Sidecar-specificMYVAR
overrides the top-level default value, and the top-levelNAMESPACE
overrides the value that would have been set via theNamespace
property.Issue reference
This PR will close issue: #28
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: