search

man-group / dapr-sidekick-dotnet

Dapr Sidekick for .NET - a lightweight lifetime management component for Dapr
Apache License 2.0
175 stars 21 forks source link

Delay Sidecar Startup until Host Application Started #37

Closed badgeratu closed 2 years ago

badgeratu commented 2 years ago

Description

Delay startup process in DaprSidecarHostedService until IHostApplicationLifetime.ApplicationStarted is signaled, indicating the port is open and the middleware pipeline is completed.

Issue reference

We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.

Please reference the issue this PR will close: #36

Checklist

Please make sure you've completed the relevant tasks for this PR, out of the following list:

codecov-commenter commented 2 years ago

Codecov Report

Merging #37 (657a6a1) into main (0fb8a6d) will decrease coverage by 0.35%. The diff coverage is 44.44%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main      #37      +/-   ##
==========================================
- Coverage   88.98%   88.63%   -0.36%     
==========================================
  Files         104      104              
  Lines        2252     2270      +18     
  Branches      460      471      +11     
==========================================
+ Hits         2004     2012       +8     
- Misses        158      161       +3     
- Partials       90       97       +7
Flag Coverage Δ
net35 85.67% <ø> (ø)
net48 86.96% <ø> (ø)
net5.0 87.99% <44.44%> (-0.37%) :arrow_down:

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ick.AspNetCore/Sidecar/DaprSidecarHostedService.cs 73.46% <44.44%> (-16.86%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0fb8a6d...657a6a1. Read the comment docs.