Closed IliasP91 closed 11 months ago
Many thanks for the contribution! The one thing I'd request is rather than change the default ControllerSample
I think the custom secrets/startup example should be in a new sample project, specifically named to indicate it represents a pattern for loading secrets at startup and with a README alongside it. In the future we will look at supporting secrets pre-loading natively in the AddDaprSidekick()
method rather than using the builder, as the latter is really intended for non-ASP.NET Core apps.
Many thanks for the contribution! The one thing I'd request is rather than change the default
ControllerSample
I think the custom secrets/startup example should be in a new sample project, specifically named to indicate it represents a pattern for loading secrets at startup and with a README alongside it. In the future we will look at supporting secrets pre-loading natively in theAddDaprSidekick()
method rather than using the builder, as the latter is really intended for non-ASP.NET Core apps.
not a problem at all, ill update it in the next couple of days
as for your suggestion that would be better, however probably a new internal process or component would be required as it needs to happen a lot earlier than the hosted service
regardless ill post back when i update this PR
@badgeratu thanks for approving and merging this QQ i there a plan for the next release? thanks
Itβs released now π https://github.com/man-group/dapr-sidekick-dotnet/releases/tag/v1.2.2
From: Ilias @.> Sent: Monday, October 9, 2023 10:19 AM To: man-group/dapr-sidekick-dotnet @.> Cc: Simon Jones @.>; Mention @.> Subject: Re: [man-group/dapr-sidekick-dotnet] Feature/add working directory override (PR #59)
@badgeratu https://github.com/badgeratu thanks for approving and merging this QQ i there a plan for the next release? thanks
β Reply to this email directly, view it on GitHub https://github.com/man-group/dapr-sidekick-dotnet/pull/59#issuecomment-1752625729 , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG36I6TVR6QG3GNDSHGWILX6O6OTAVCNFSM6AAAAAA5KCGVOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGYZDKNZSHE . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABG36IZWGYYPGLQJ5PETW43X6O6OTA5CNFSM6AAAAAA5KCGVOCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIO3ZEC.gif Message ID: @. @.> >
Itβs released now π https://github.com/man-group/dapr-sidekick-dotnet/releases/tag/v1.2.2 From: Ilias @.> Sent: Monday, October 9, 2023 10:19 AM To: man-group/dapr-sidekick-dotnet @.> Cc: Simon Jones @.>; Mention @.> Subject: Re: [man-group/dapr-sidekick-dotnet] Feature/add working directory override (PR #59) @badgeratu https://github.com/badgeratu thanks for approving and merging this QQ i there a plan for the next release? thanks β Reply to this email directly, view it on GitHub <#59 (comment)> , or unsubscribe https://github.com/notifications/unsubscribe-auth/ABG36I6TVR6QG3GNDSHGWILX6O6OTAVCNFSM6AAAAAA5KCGVOCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTONJSGYZDKNZSHE . You are receiving this because you were mentioned. https://github.com/notifications/beacon/ABG36IZWGYYPGLQJ5PETW43X6O6OTA5CNFSM6AAAAAA5KCGVOCWGG33NNVSW45C7OR4XAZNMJFZXG5LFINXW23LFNZ2KUY3PNVWWK3TUL5UWJTTIO3ZEC.gif Message ID: @. @.> >
Legend! FYI I had a quick look to see if I could relatively easily kick off the svc earlier, didn't go too far, I'll have another look next weekend, otherwise the approach in the sample has been working fine for us for a bout a week or so now
Description
Issue reference
https://github.com/man-group/dapr-sidekick-dotnet/issues/57 https://github.com/man-group/dapr-sidekick-dotnet/issues/58
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: