man-group / dtale

Visualizer for pandas data structures
http://alphatechadmin.pythonanywhere.com
GNU Lesser General Public License v2.1
4.72k stars 400 forks source link

Re-opening D-Tale Chart Colors GitHub Issue #325? #843

Closed Valence-Shinei closed 8 months ago

Valence-Shinei commented 8 months ago

I'm experiencing the same issue as described in

github.com/man-group/dtale/issues/325

😰.

I tried to understand the fix, but is there a configuration setting or file I need to change somewhere? I don't see a colorway option in the D-Tale interface and the demonstrated export issues shared in the above issue makes it difficult to see due to the blue on blue lack of contrast when exporting charts as .html. Also, the export .png seems to simply spin for 10+ min ...

My apologies if this isn't the proper way to engage with this issue 😅!

I'm currently running D-Tale 3.8.1 and Plotly 5.9.0.

Thank you in advance for your time and consideration of my request 🙏!

aschonfeld commented 8 months ago

@Valence-Shinei I see what you're talking about with the background being different in the PNG export versus the actual app: scatter_export_1706644494190 image

I'll look into why its different. There isn't a way to change the colorway from a user perspective. It was just a small code update in that previous issue.

As for the spinning I can't really recreate that unless I just try to create a scatter with a ton of points, but then just trying to create the chart , let alone one that can be exported to a PNG, just spins forever.

aschonfeld commented 8 months ago

ok I've got it looking like this now: scatter_export_1706645516763

I'll keep you posted on when this update is released

Valence-Shinei commented 8 months ago

Thank you kindly Andrew 🤝! That was precisely the concern I was noticing, especially since the white background provides a greater contrast against the blue plot points.

To clarify on the spinning 😅, I was noticing this issue when exporting to a self contained .html file, which had the same issue you demonstrated above. Such a .html file would generate quickly, less than 30 seconds, and would be about 7 MB in size. When I attempted to export instead as a .png file, I was unsuccessful, since the new tab in Chrome would simply spin. I think I killed the tab after 10 min. I tried this a couple of times without success.

However, since you were able to produce the above, it must be an issue with my machine that I'll have to troubleshoot. I prefer the .html file and its interactivity over the .png anyway 😉.

Thank you for clarifying on the colorway configuration as well. I appreciate you taking a look at this so quickly and I look forward to the update when it is ready (no rush 🤝)!

aschonfeld commented 8 months ago

@Valence-Shinei just released v3.10.0 to pypi (should be on conda-forge soon) with this fix included.

Valence-Shinei commented 8 months ago

You and team are a beautiful machine 🙏😎🤝!

Many thanks for such a speedy resolution! I tested it out and the crisp clear background draws out the desired high contrast 🤩🙌!