search

man-group / mdf

Data-flow programming toolkit for Python
MIT License
169 stars 53 forks source link

mdf run() fails to incorporate tzinfo when passed a pandas.DateRange #13

Open willferreira opened 10 years ago

willferreira commented 10 years ago

pandas.DateRange is deprecated. If run() is passed a date_range parameter constructed from pandas.DateRange it will actually be of time DatetimeIndex. Consequently run() fails to extract tzinfo from date_range since it checks to see if date_range has type pandas.DateRange first. The workaround is to pass in a tzinfo parameter explicitly to run(). The fix should be to remove the dependence on pandas.DateRange.

SleepingPills commented 10 years ago

I understand your reasoning but it might be a bit surprising to a user that the timezone is not automatically extracted from the date range object. I'm easy either way though...

On 06.12.2013, at 10:55, William Ferreira notifications@github.com wrote:

pandas.DateRange is deprecated. If run() is passed a date_range parameter constructed from pandas.DateRange it will actually be of time DatetimeIndex. Consequently run() fails to extract tzinfo from date_range since it checks to see if date_range has type pandas.DateRange first. The workaround is to pass in a tzinfo parameter explicitly to run(). The fix should be to remove the dependence on pandas.DateRange.

— Reply to this email directly or view it on GitHubhttps://github.com/ahlmss/mdf/issues/13 .