search

man-group / notebooker

Productionise & schedule your Jupyter Notebooks as easily as you wrote them.
GNU Affero General Public License v3.0
848 stars 80 forks source link

fixing cron conversion #147

Closed marcinapostoluk closed 12 months ago

marcinapostoluk commented 1 year ago

A while ago a change was made to convert between crontab and apscheduler days of week - https://github.com/man-group/notebooker/pull/115/commits/cadba46ec9f02715d3b035f478b2ad96cf17d920#diff-490c71dda64b8e9aab6c585e5cab2133d798ff6b14f792dcf85ca667aa69be90

However that conversion was done only one way and each time ones saves the schedule the conversion happens shifting the days incorrectly.

A fix is to shift the days back to the crontab format when presenting to the UI

jonbannister commented 1 year ago

LGTM. Please rebase and add to the CHANGELOG :)