search

man-group / pkglib

Company-centric Python packaging and testing library
39 stars 22 forks source link

Submit page objects pattern to the Selenium project? #49

Open eeaston opened 10 years ago

eeaston commented 10 years ago

Hi there (sorry it's been so long!) I was thinking - the Page Objects test code is really very useful, and a lot more flexible than many of the other implementations of this around the web. Do you think it would be a good idea to submit it to be included in the Python Selenium project itself? It's kinda hidden away in here a bit.

Wilfred commented 10 years ago

Hello! No need to apologise :)

There's a lot going on in this repo. Too much I think. I think it would be clearer if pkglib-testing was a separate repo (other than the 'creating pkglib packages' bit). We could definitely go a step further and factor out the mocking code, the selenium bits, the fixtures and so on.

So, I'd be tempted to just create a selenium-objects repo and move the code out of pkglib. That way it would be readily reusable for anyone, even if they're not in the pkglib world. Upstream Selenium could then accept or refuse addition, but that wouldn't inhibit usage. It would also give us an obvious place to put documentation for Page Objects.

Does that sound sensible? It's open source, so you don't need my permission if you fancy forking and just adding a link from the README to the new repo.

eeaston commented 10 years ago

Very sensible. I was thinking of doing the same sort of thing for all the pytest server fixtures, and follow the pattern of pytest_xxx plugins that are available on pypi.python.org. The server fixtures could all live in the same repo but deploy as separate packages, being that many of them are very small. So - to keep the project history I'll just fork this whole repo, rename it, then cut down the project to just the page objects related things, preserving the link in the README.

Wilfred commented 10 years ago

:+1: