search

man-group / pytest-plugins

A grab-bag of nifty pytest plugins
MIT License
568 stars 85 forks source link

Test against Python 3.7 and support pytest 4.x #130

Closed jcfr closed 5 years ago

jcfr commented 5 years ago

This PR adds support for Python 3.7 and will be updated to address #100, #110, #92 , #125

jcfr commented 5 years ago

For reference, setting COVERALLS_REPO_TOKEN is required to use coveralls python client or to submit coverage results using curl. Failing to do so reports Couldn't find a repository matching this job. See https://github.com/lemurheavy/coveralls-public/issues/487 and https://github.com/z4r/python-coveralls#configuration

jcfr commented 5 years ago

@bmoscon @eeaston @javefang This is now ready for final review.

It addresses issues #125 #122 #110 and #100

After getting your feedback, I will also:

Once, this is done it would be great to cut a release and have all the wheels uploaded to pypi. This will all me to fix testing associated with cmake-python-distributions, ninja-python-distributions and scikit-build

Cc: @thewtex

bmoscon commented 5 years ago

@eeaston @javefang looks good to me, but given the size and scope of the change I'd like to have another review before merging

jcfr commented 5 years ago

Et voila. The last two updates have been pushed. Now looking forward final reviews.

In the mean time and waiting new official wheels are released, temporary ones are available at https://github.com/jcfr/pytest-plugins/releases/tag/v1.7.0.dev15

They can be installed using:

pip install pytest-virtualenv -f https://github.com/jcfr/pytest-plugins/releases/tag/v1.7.0.dev15 --pre
javefang commented 5 years ago

LGTM, thanks for the contribution! @eeaston , I tested the branch against pytest==3.1.0 which is also a pass.

ssbarnea commented 5 years ago

When can have this merged as now I went into conflicts caused by:

pytest-verbose-parametrize 1.5.1 has requirement pytest<4.0.0, but you have pytest 4.3.1.
jcfr commented 5 years ago

@ssbarnea As a temporary workaround, you could install corresponding development wheels. See https://github.com/manahl/pytest-plugins/pull/130#issuecomment-471149935

ssbarnea commented 5 years ago

@jcfr Thanks for the hint but I will have to pass. I would not be able to do this even if the pre-release would be on posted on pypi as we have a policy of not using unreleased dependencies (not a real surproise).

For the moment I added a <4.0.0 on pytest with a comment blaming pytest-verbose-parametrize as being the reason.

bmoscon commented 5 years ago

@eeaston this ok to merge? I'll probably squash and merge it soon unless you want to review/comment

jcfr commented 5 years ago

'll probably squash and merge it soon unless you want to review/comment

For convenience, here is a squashed version of that same topic:

https://github.com/manahl/pytest-plugins/pull/134

eeaston commented 5 years ago

Hi guys apologies for the tardy replies. @jcfr - amazing PR, many thanks for the hard work, I'll start going through it.

eeaston commented 5 years ago

LGTM, many thanks! I'll approve the squashed PR #134

jcfr commented 5 years ago

I'll approve the squashed PR #134

Closing this one.