search

man-group / pytest-plugins

A grab-bag of nifty pytest plugins
MIT License
568 stars 85 forks source link

Fix pytest-devpi-server test on py34 updating "ruamel.yaml" requirements #138

Closed jcfr closed 5 years ago

jcfr commented 5 years ago

Since no python 3.4 wheels are distributed following ruamel.yaml 0.15.94, this commit updates the requirements to ensure the package still be installed using python 3.4

It addresses the following error:

  Searching for ruamel.yaml>=0.14.2
  Reading https://pypi.org/simple/ruamel.yaml/
  Downloading https://files.pythonhosted.org/packages/a2/f7/63f04dd8a572b13a41a62b29eb52b64a2136249cc42a933f05d890033eac/ruamel.yaml-0.15.96.tar.gz#sha256=343ace5ffbab036536a3da65e4cfd31b8292388a389f6305744984581a479b2a
  Best match: ruamel.yaml 0.15.96
  Processing ruamel.yaml-0.15.96.tar.gz
  Writing /tmp/easy_install-gpfme0if/ruamel.yaml-0.15.96/setup.cfg
  Running ruamel.yaml-0.15.96/setup.py -q bdist_egg --dist-dir /tmp/easy_install-gpfme0if/ruamel.yaml-0.15.96/egg-dist-tmp-ncvinjfp
  minimum python version(s): [(2, 7), (3, 5)]
  error: Setup script exited with 1

Adapted from scikit-build/scikit-ci@d8311a3f393

eeaston commented 5 years ago

Heh, I was literaly just typing out the fix for this - happy to take your change though thanks!

jcfr commented 5 years ago

@eeaston this should address the circleci failure. To support projects tested against Python 3.4, I suggest we try to fix the failure (despite the recent EOL of python 3.4)

jcfr commented 5 years ago

Look like the fix is working out :tada: since I faced the same issue few days ago, I went ahead :smile: