Open kloczek opened 3 years ago
Hi there, this looks like an issue with python2 compatibility which we will shortly be dropping - I'll let you know when it's released and you can check again if it's still a problem.
Other thing was pinning more-itertools version solved in 6e2d3e58. I think that it would be good to make new release of the pytest plugins because currently many known issues already have been resolved and merged to the git repo.
I was making some changes to the pytest-profiling plugin & ran into this issue too. It's because, per the setuptools' v52.0 change, the easy_install entrypoint is no longer installed. I started making serious changes to pytest-virtualenv before I realized a potential hack might be available. Sure enough, if I change the pkg_name arguments of the test_profile_intergration.py's usage of VirtualEnv.install_package() to use 'install ' as a prefix, specify installer='pip' rather than the default 'easy_install', then the install_package will successfully install requested packages need by the tests. That is,
venv.install_package("install more-itertools", installer='pip')
...
venv.install_package("install 'pytest-profiling>1.7.1' ", installer='pip' ) # <- my locally built 1.7.2, uploaded wheel
For my locally developed profiling wheel, I built the wheel, uploaded to a devpi index, then prior to running the integration tests, defined PIP_EXTRA_INDEX_URL to point the test process to that index. It works with pytest-virtualenv 1.7.0. Lucky hack. And it, of course, forces every requested package to be installed from an index, bypassing the develop mode installs. That's why I had to use the local devpi index.
Any chance to make new release of those modules? Last one was in 2019 ..
Hi Tomas, I've got some local changes to the pytest-profiling plugin (my recent fork.) The changes add a number of options for controlling the use of the pstats.Stats methods, options for providing the ordered list of restrictions. And options to pass through gprof2dot options.
I've added unit & integration tests for these changes as well. We've been using the changes (1.7.2?) for several weeks now with no issues encountered.
I'll submit the PR either today or tomorrow. -Steve Hespelt
From: Tomasz Kłoczko @.> Sent: Thursday, April 7, 2022 7:41 AM To: man-group/pytest-plugins @.> Cc: Steven Hespelt @.>; Comment @.> Subject: Re: [man-group/pytest-plugins] pytest-profiling 1.7.0: pytest is failing (#185)
CAUTION: This email originated from outside the organization. Please do not click links or open attachments unless you recognize the sender and know the content is safe.
Any chance to make new release of those modules? Last one was in 2019 ..
- Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fman-group%2Fpytest-plugins%2Fissues%2F185%23issuecomment-1091632118&data=04%7C01%7Cshespelt%40stevens.edu%7Ce14eaf809c904999625c08da188b8427%7C8d1a69ec03b54345ae21dad112f5fb4f%7C0%7C0%7C637849284753690618%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=Kc8srbUnkfaJJggyb6xWU%2BPq5b6uSQ78j1sDWfFKjG8%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ6EXXF5RJT7QR7IF5WIGW3VD3CVPANCNFSM5B2YVYZQ&data=04%7C01%7Cshespelt%40stevens.edu%7Ce14eaf809c904999625c08da188b8427%7C8d1a69ec03b54345ae21dad112f5fb4f%7C0%7C0%7C637849284753690618%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=SHf26yI2BoAl858wuGQhwrlXoLWn01IvWcIy8SDbjyA%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>
OK .. please let me know when tose PRs will be added. I'll be glad to help test that 😄
Hi Tomas, Sorry for the delay, probably a few more days – I’ve been ill the past 4-5 days. Turns out, I’m not that special after all… As soon as I can trust my brain for more than a few minutes, I’ll add the PR. -Steve
From: Tomasz Kłoczko @.> Sent: Saturday, April 9, 2022 10:32 AM To: man-group/pytest-plugins @.> Cc: Steven Hespelt @.>; Comment @.> Subject: Re: [man-group/pytest-plugins] pytest-profiling 1.7.0: pytest is failing (#185)
CAUTION: This email originated from outside the organization. Please do not click links or open attachments unless you recognize the sender and know the content is safe.
OK .. please let me know when tose PRs will be added. I'll be glad to help test that 😄
— Reply to this email directly, view it on GitHubhttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fman-group%2Fpytest-plugins%2Fissues%2F185%23issuecomment-1094044146&data=04%7C01%7Cshespelt%40stevens.edu%7C8b7fb9ec847b49e6f6e008da1a35b928%7C8d1a69ec03b54345ae21dad112f5fb4f%7C0%7C0%7C637851115305698886%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=txlFu8xqVzJq00W6v0cXvjaebMAkTD%2BhAKC8GVeqAQk%3D&reserved=0, or unsubscribehttps://nam02.safelinks.protection.outlook.com/?url=https%3A%2F%2Fgithub.com%2Fnotifications%2Funsubscribe-auth%2FAJ6EXXBBOCKQMUMAU6IZSB3VEGIGNANCNFSM5B2YVYZQ&data=04%7C01%7Cshespelt%40stevens.edu%7C8b7fb9ec847b49e6f6e008da1a35b928%7C8d1a69ec03b54345ae21dad112f5fb4f%7C0%7C0%7C637851115305698886%7CUnknown%7CTWFpbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%7C3000&sdata=CvPBxwGbV0wj6sJtuKmi4Rp8iOdAFcQg4krdjJxIytE%3D&reserved=0. You are receiving this because you commented.Message ID: @.**@.>>
Gentle ping .. any update? 😋 Looking on https://github.com/man-group/pytest-plugins/compare/v1.7.0...master I see 100 commits since last release which was in 2019. Any plans to release new version?🤔
I'm trying to package your module as rpm package. So I'm using typical in such case build, install and test cycle used on building package from non-root account:
May I ask for help because few units are failing: