search

man-group / sparrow

C++20 idiomatic APIs for the Apache Arrow Columnar Format
Apache License 2.0
19 stars 9 forks source link

Refactoring: value type of the arrays #187

Closed JohanMabille closed 4 weeks ago

JohanMabille commented 1 month ago

The "dynamic" value type should be a variant similar to that of the current implementation. In addition to the scalar and string types it already contains, the variant should also hold a recursive proxy to a list type, for the different list layouts.

This variant should also std::monostate to handle missing values. The nullable type originally introduced for that might be complicated to use with nested layouts. This can be explored later.

JohanMabille commented 4 weeks ago

Actually using the nullable is fine and easy, no need for the monostate.

JohanMabille commented 4 weeks ago

Implemented in #210