search

mana-ethereum / mana

Ethereum full node implementation written in Elixir.
Other
273 stars 47 forks source link

Support Capabilities with Overlapping Packets 706 #720

Closed willmeister closed 5 years ago

willmeister commented 5 years ago

Fixes issue #706 where eth and par cannot support the same packet types.

ayrat555 commented 5 years ago

@willmeister can common methods be moved into a separate module?

willmeister commented 5 years ago

@ayrat555 yes, we could move common methods, but they're not guaranteed to be common. They just happen to be at the moment. For instance, the par capability could choose to re-define parts of the shared eth packets and/or how to handle them, at which point we'd have to pull them apart again.