what are the rules/etiquette for merging pull requests?

manaakiwhenua / nzsluc

New Zealand Standard Land Use Classification Framework

Creative Commons Attribution 4.0 International

7 stars 0 forks source link

Closed brandonnodnarb closed 6 months ago

brandonnodnarb commented 8 months ago

Do we not merge our own? Does there need to be a 2 person review prior to merge?

How do we want to do this?

alpha-beta-soup commented 8 months ago

Keep it simple.
Smaller is better, but too small is silly.
Make substantial changes, but scope them to precise parts (e.g. one particular principle).
Superficial changes (typos, formatting) can be merged unilaterally.
Discuss non-superficial changes for consensus before merging.

alpha-beta-soup commented 8 months ago

Review marked as complete = ready to merge (subject to PR author seeking another review; Github only allows one reviewer at a time)

alpha-beta-soup commented 8 months ago

We could add a CONTRIBUTING.md to capture any ideas here?