search

manaakiwhenua / vector2dggs

DGGS indexer for vector data
https://pypi.org/project/vector2dggs/
GNU Lesser General Public License v3.0
6 stars 0 forks source link

Allow CRS configuration #4

Closed alpha-beta-soup closed 1 year ago

alpha-beta-soup commented 1 year ago

Currently EPSG:2193 is hardcoded for the purposes of computing area (for Katana cut).

This won't work outside of NZ. We could make this a CLI argument, but that requires communicating an internal concept. EPSG 6933 is good non-polar default, but we should allow it as an option, or else polar regions won't work properly.

Make 6933 the default, mention 6931/2 as good alternatives for polar data, make make CRS an option (using EPSG code, integer).

alpha-beta-soup commented 1 year ago

Actually we could default to the CRS of the input...

ChocopieKewpie commented 1 year ago

cut_threshold help should be dependent of crs and reflect the layers nature.

ChocopieKewpie commented 1 year ago

Fixed at commit a786fb8723708481cd1f692ab2b7706262c1e0e6