search

manaflair / redux-batch

Enhance your Redux store to support batched actions
174 stars 12 forks source link

Deprecate package? #15

Closed ghost closed 5 years ago

ghost commented 5 years ago

Currently doesn't work with the latest eco-system.

arcanis commented 5 years ago

What exactly is broken? What would be needed to fix it?

ghost commented 5 years ago

Its 2 years old and the maintainer has given up on it. It's just good to document these things.

arcanis commented 5 years ago

I'm the author and maintainer, I haven't given up on it 😄

I think the package is basically feature complete and just doesn't need more development time. If it's broken because of BC-breaking changes in Redux it should be fixed (and I would review and merge PR in this regard), but I don't see the value in deprecating the whole package 🙂

ghost commented 5 years ago

That's fine. I know you have your hands in a lot of pies, I just don't think we need another tool especially when simple things like this get missed in the docs.

yield [
            put(action),
            put(action)
        ]

not:

yield put([action, action])
Noitidart commented 5 years ago

Oh whoa @mpash does that really batch it? Doing yeild [ put(action), put(action ]? I don't think it would no?

ghost commented 5 years ago

@Noitidart https://github.com/redux-saga/redux-saga/issues/459#issuecomment-235808470

Noitidart commented 5 years ago

Holy heck this is amazing!!!! Thank you!!! I've been working with this for a year and didn't realize that!! This super simplifies a TON!

ghost commented 5 years ago

@arcanis I made a PR, granted you have time to review it.