search

managarm / frigg

Lightweight C++ utilities and algorithms for system programming
MIT License
56 stars 20 forks source link

Make gtest dependency optional or add a wrap #34

Closed avdgrinten closed 2 years ago

avdgrinten commented 2 years ago

Currently, this makes downstream CI fail: https://github.com/managarm/managarm/runs/6953595720

ArsenArsen commented 2 years ago

FIxed by https://github.com/managarm/bootstrap-managarm/commit/9a42fa2957eca350e44c4f7b7cd479d6471310a3 (the dep is already optional, but enabled by default, and I forgot to submit a matching patch to disable it downstream. I can make the default auto setting be equivalent to not meson.subproject() and has_gtest or such, if that's more desireable).