search

managed-commons / SvgNet

Fork of the SVG library for .NET that makes a GdiGraphics that "draws" on a SVG model
BSD 3-Clause "New" or "Revised" License
84 stars 37 forks source link

Include net5.0-windows target #40

Closed glopesdev closed 3 years ago

glopesdev commented 3 years ago

For an improved build experience on projects migrating WinForms applications to .NET 5.0 it would be great to include a new target framework for net5.0-windows which bypasses the need for System.Drawing.Common altogether. This is the official equivalent of the old .NET framework windows forms, for projects targeting the windows platform.

The change is quite simple, I will add a pull request shortly to demonstrate it and also include conditional removal of System.Drawing.Common for targets which do not require it.

monoman commented 3 years ago

Thanks, I've made TargetFrameworks conditionally include net461 and net5.0-windows only when building in Windows, which is the case when I generate the package to publish on Nuget, so the official package has all 5 versions of the dll, while building in ubuntu as done in the GitHub actions it only compiles for netstandard2.0, netstandard2.1 and net5.0.

glopesdev commented 3 years ago

Thanks @monoman that's great. I noticed that the NuGet packages seem to be published only on GitHub now? Looking at the NuGet gallery link it seems the latest version is 2.1.1: https://www.nuget.org/packages/SvgNet

Is there an alternate repository we should use to target the library in other Visual Studio projects?

monoman commented 3 years ago

I've not automated publishing to Nuget Gallery, yet. I will do it manually once more.

Rafael Teixeira O..:.)oooo

On Thu, Apr 22, 2021 at 3:04 PM glopesdev @.***> wrote:

Thanks @monoman https://github.com/monoman that's great. I noticed that the NuGet packages seem to be published only on GitHub now? Looking at the NuGet gallery link it seems the latest version is 2.1.1: https://www.nuget.org/packages/SvgNet

Is there an alternate repository we should use to target the library in other Visual Studio projects?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/managed-commons/SvgNet/issues/40#issuecomment-825069696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZ6NFAOMUYKJQBBBIUUXTTKBQLFANCNFSM43JGRTQQ .

monoman commented 3 years ago

Version 2.1.6 published and listed: https://www.nuget.org/packages/SvgNet

Rafael Teixeira O..:.)oooo

On Thu, Apr 22, 2021 at 3:04 PM glopesdev @.***> wrote:

Thanks @monoman https://github.com/monoman that's great. I noticed that the NuGet packages seem to be published only on GitHub now? Looking at the NuGet gallery link it seems the latest version is 2.1.1: https://www.nuget.org/packages/SvgNet

Is there an alternate repository we should use to target the library in other Visual Studio projects?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/managed-commons/SvgNet/issues/40#issuecomment-825069696, or unsubscribe https://github.com/notifications/unsubscribe-auth/AABZ6NFAOMUYKJQBBBIUUXTTKBQLFANCNFSM43JGRTQQ .