managed-commons / SvgNet

Fork of the SVG library for .NET that makes a GdiGraphics that "draws" on a SVG model
BSD 3-Clause "New" or "Revised" License
84 stars 37 forks source link

Update SvgTextElement constructor #53

Closed MartinJSoles closed 2 years ago

MartinJSoles commented 2 years ago

The constructor that accepts two floats for X and Y is implicitly converting to SvgLength objects with unknown length types. This constructor should be marked obsolete.

A new constructor that accepts two SvgLength objects for X and Y should be used instead.

monoman commented 2 years ago

You are right, maybe this implicit conversion operator may also need to be deprecated if it doesn't assume some default length type, but I'll think about it a little more.

Thank you