search

managed-components / hubspot

Managed Component for Hubspot
Other
1 stars 2 forks source link

Fix up form submission to be server side #2

Closed Manouchehri closed 1 year ago

Manouchehri commented 1 year ago

Solves #1.

Also, the old method seemed... really bad? It wasn't even submitting the form correctly for me; I tried to troubleshoot what was wrong with it, but it was just faster to ditch it and do things server-side properly to begin with.

bjesus commented 1 year ago

Thanks for this! I'm not sure why it was client side, seems like our pre-MC version was server side too.

bjesus commented 1 year ago

This on the hand seems useful, because forms are confirmed to work well server-side and if I'm understanding you correctly, it sounds like you tested it and it works well with the changes?

Manouchehri commented 1 year ago

you tested it and it works well with the changes?

Yes.

Manouchehri commented 1 year ago

Reclosing as I see server-side-2 is okay and don't want a merge conflict. =) (Will leave a comment on #3.)