Changed theme for Hacktoberfest 2021

[neeraj15022001]

Issue: #34 Issue Opener: @mananchawla2005 Status: Implemented Additional Information: API work still to be done Working Video : https://user-images.githubusercontent.com/55191873/133342627-d786cd37-fc35-47aa-8159-f7c783898952.mov

[mananchawla2005]

Hey, nice work, can u switch the destination branch to dev instead of master. Also should I merge it rn or you'll add further commits related to api here only?

[mananchawla2005]

Also its not responsive yet, hope you working on it :) Once it is reviewed and merge I will add hacktoberfest-accepted label once the hacktoberfest starts so that u get once successful pr

[mananchawla2005]

One thing more, the dark mode preference should be stored in local storage :) as it was earlier so that it eases the users.

[neeraj15022001]

Hey, nice work, can u switch the destination branch to dev instead of master. Also should I merge it rn or you'll add further commits related to api here only?

Ok i will switch the branch

[neeraj15022001]

One thing more, the dark mode preference should be stored in local storage :) as it was earlier so that it eases the users.

So you want to persist dark mode, okay i will make that change in this code only

[mananchawla2005]

Hey, nice work, can u switch the destination branch to dev instead of master. Also should I merge it rn or you'll add further commits related to api here only?

Ok i will switch the branch

Yup great work though. Take your time. There is a lot of time left for hf 2021. Hope the final result comes out best :)

[neeraj15022001]

@mananchawla2005 added theme persistancy

[mananchawla2005]

@neeraj15022001

[neeraj15022001]

@mananchawla2005 review this, in case any bug please ask for changes again.

[neeraj15022001]

The text don't go beyond that. Rest is fine :)

Okay i will check this shortly

[mananchawla2005]

The text don't go beyond that. Rest is fine :)

Okay i will check this shortly

Also idk but for some weird reason, Not able to select the text inside the text box. Give a quick check if u having the same problem at your end and try fixing it if u are able to spot the issue. Everything seemed fine to me. Dk why it happened.

[neeraj15022001]

The text don't go beyond that. Rest is fine :)

Okay i will check this shortly

Also idk but for some weird reason, Not able to select the text inside the text box. Give a quick check if u having the same problem at your end and try fixing it if u are able to spot the issue. Everything seemed fine to me. Dk why it happened.

i disabled selecting on whole page, should i change it?

[mananchawla2005]

The text don't go beyond that. Rest is fine :)

Okay i will check this shortly

Also idk but for some weird reason, Not able to select the text inside the text box. Give a quick check if u having the same problem at your end and try fixing it if u are able to spot the issue. Everything seemed fine to me. Dk why it happened.

i disabled selecting on whole page, should i change it?

Oh yea, enabling it would be better ig, it feels weird.

[neeraj15022001]

@mananchawla2005 fixed input field size and tested on all responsive designs, anything else containing bug as of your knowledge?

[mananchawla2005]

Maybe U can enable select on the page again. And yea Its good now :) no bugs which I can see @neeraj15022001

[neeraj15022001]

Maybe U can enable select on the page again. And yea Its good now :) no bugs which I can see @neeraj15022001

just skipped from my mind just a second lemme make changes

[neeraj15022001]

@mananchawla2005 done from my end

[mananchawla2005]

@mananchawla2005 done from my end

Yup The UI seems good now. Only API left now. U can commit that to this same pull request only.

[neeraj15022001]

i just changed the pull request merging branch to dev you can merge later( during hacktoberfest) i will keep working on this one only

[neeraj15022001]

we will make this up and working by 2-3 october so it can come in use during hacktoberfest

[mananchawla2005]

@neeraj15022001 Well u can do it now also and even If I merge it now, You will get your contribution later too. Last year it was the same. I will just merge it now and add the label of "hacktoberfest-accepted" later. Also It would be nice if u can work on this now since I decided to change the hosting server and have to set it up and test it once and then we can find some bugs if there will be any.

[neeraj15022001]

Not a problem it's your wish whenever you want to merge.

[mananchawla2005]

Not a problem it's your wish whenever you want to merge.

Yup I was just waiting for the api stuff. Btw u know why its happening? Like its sending the request to the endpoint but the alert modal box is not coming up. U disabled something? or is it happening with u too?

[neeraj15022001]

for now i commented out modal code and i haven't seen and tested API yet will start working on that shortly

[mananchawla2005]

@neeraj15022001 okok sure :)

[neeraj15022001]

@mananchawla2005 you can close this

[mananchawla2005]

@mananchawla2005 you can close this

merge or close?

[neeraj15022001]

Merge

[neeraj15022001]

Will this be counted towards hf2021?

[mananchawla2005]

Will this be counted towards hf2021?

Yup I will make sure it does, Just have to add the label when the hf starts