Add a feature to lock to a particular aspect ratio

manancodes / Screenbows

Magical colours for your screen

https://manancodes.github.io/Screenbows/

11 stars 9 forks source link

Add a feature to lock to a particular aspect ratio #17

Open manancodes opened 8 months ago

manancodes commented 8 months ago

There should be an option to either lock the aspect ratio or use from the presets to download for common screen sizes.

Feel free to use chatGPT or other AI.

Shuva15 commented 8 months ago

hey @manancodes I am working on this issue, I am implementing the preset ratios as a dropdown, but I didn't get what you mean by lock the aspect ratio

Screenbows — Mozilla Firefox 28-10-2023 20_46_38

my idea is that I can put a lock button in between the height and width box and if clicked height and width box will stop taking inputs, and also I wanted to know that you marged a lot of PRs but the github pages webside isn't updated with all the new features, I wanted to know that is it a CI/CD problem ( I don't know anything about CI/CD ), or is it intentionally done by you. Cause if it is I would like to learn about CI/CD

Shuva15 commented 8 months ago

Screenbows — Mozilla Firefox 29-10-2023 01_06_14

manancodes commented 8 months ago

Having a lock between height and width and if it is clicked, the aspect ratio will remain same. Let's say you select 1:1 and the width and height is 500px, if I change height to 600, width will also change.

manancodes commented 8 months ago

The changes have not been published yet, yes. But I'm working with somebody on an automated deployment script which will be up soon.

Shuva15 commented 8 months ago

@manancodes I am done with the preset dropdown feature though, can I make a PR for that

https://github.com/manancodes/Screenbows/assets/107918666/18d7eb74-49bb-448f-ac19-c9599a4cf610

and I am still confused about the ratio lock feature, if you can explain a little more