search

manancodes / Screenbows

Magical colours for your screen
https://manancodes.github.io/Screenbows/
11 stars 9 forks source link

Remove legacy code #29

Closed manancodes closed 8 months ago

manancodes commented 8 months ago

Please go through the whole repo and try to find unused code or things which are not supposed to be there.

For example: https://github.com/manancodes/Screenbows/blob/911857b58d44f06686e0dc670bd9afd815db6fa4/src/Components/Console/index.js#L31-L36

The Shuffle word is not being used but the icon, so It can be removed.

joanita-51 commented 8 months ago

I can work on this, can I go ahead?

manancodes commented 8 months ago

I can work on this, can I go ahead?

Go ahead. I have assigned this to you.

manancodes commented 8 months ago

Another one that I found was, the buttons inside the console have 2 css classes doing the same thing. One can be removed.

joanita-51 commented 8 months ago

Another one that I found was, the buttons inside the console have 2 css classes doing the same thing. One can be removed.

Yes, I noticed that as well. Thank you @manancodes. However, It appears the word 'shuffle' is related to the 'material-symbols-outlined' class, as removing it results in the icon not being displayed.

manancodes commented 8 months ago

Another one that I found was, the buttons inside the console have 2 css classes doing the same thing. One can be removed.

Yes, I noticed that as well. Thank you @manancodes. However, It appears the word 'shuffle' is related to the 'material-symbols-outlined' class, as removing it results in the icon not being displayed.

Oh yes. You're correct. Sometimes shuffle is seen on slow rendering but I think that's fine. You can work on the other issue though.