search

manas-chaudhari / android-mvvm

MVVM on Android using RxJava and Data Binding
Apache License 2.0
501 stars 81 forks source link

replaced MvvmActivity with MvvmBinder #54

Open mike-mathieu opened 7 years ago

mike-mathieu commented 7 years ago

User can now extend any Activity. Also can be used with Fragments. Let me know what you think.

manas-chaudhari commented 7 years ago

I am not sure about this approach as of now. Extracting the logic of MvvmActivity into a separate class is a great idea as it encourages composition instead of inheritance. However, the code in MvvmActivity is very trivial, and can be easily implemented for fragments. Creating a doc in README should be enough at this point. Before providing support for fragments, I want to complete support for activities, mainly #37. That would refine the structure for Binder, which then can be extended for fragments.