Besides, there's a little logical inconsistency in this code: If you want to modify tab-line, then awesome-tab-display-line should be changed to 'tab-line; if you just want to make sure the display is correct no matter on Emacs 26 or 27, the predicate on Emacs version should be removed. I choose the latter solution.
manateelazycat
commented
3 years ago
The
set-face-attributesform is not needed.Besides, there's a little logical inconsistency in this code: If you want to modify
tab-line, thenawesome-tab-display-lineshould be changed to'tab-line; if you just want to make sure the display is correct no matter on Emacs 26 or 27, the predicate on Emacs version should be removed. I choose the latter solution.set-face-attributes是不需要的。此外还有一个小的逻辑问题：如果我们只处理
tab-line，那应该直接修改'tab-line而不是awesome-tab-display-line（因为即使是 Emacs 27，用户可能会自定义成用header-line显示 tab）；如果我们想保证用户看到的效果是对的，不管是 26 还是 27，那应该把版本的判断拿掉。我选择了后一种做法。