manateelazycat / awesome-tab

Emacs package to provide out-of-the-box configuration to use tabs.
384 stars 38 forks source link

Replace helm-build-sync-source with helm-make-source #109

Closed twlz0ne closed 2 years ago

twlz0ne commented 2 years ago

The macro helm-build-sync-source will cause an Invalid function error when compiling byte code:

Debugger entered--Lisp error: (invalid-function helm-build-sync-source)
  helm-build-sync-source(\"Awesome-Tab Group\" :candidates awesome-tab-get-groups
  :action ((\"Switch to group\" . awesome-tab-switch-group)))
  awesome-tab-build-helm-source()
  (closure (t) nil (awesome-tab-build-helm-source))()"

There are 2 ways to solve it:

  1. add (eval-when-compile (require 'helm-source nil t)).
  2. replace helm-build-sync-source with helm-make-source.

See https://github.com/jacktasia/dumb-jump/issues/224 for more infomation.


Minimal config to reproduce:

(progn
  (toggle-debug-on-error)
  (quelpa '(awesome-tab :repo "manateelazycat/awesome-tab" :fetcher github))
  (require 'awesome-tab)
  (awesome-tab-build-helm-source))
manateelazycat commented 2 years ago

感谢补丁!