search

manateelazycat / lsp-bridge

A blazingly fast LSP client for Emacs
GNU General Public License v3.0
1.42k stars 205 forks source link

Use file-local no-byte-compile and no-native-compile variables #823

Closed phil-s closed 8 months ago

phil-s commented 8 months ago

Looking at the readme, there are strong warnings to not allow byte- or native-compilation; but even though Emacs has provisions for enforcing this, they don't appear to be used.

You should add file-local no-byte-compile and/or no-native-compile variables to each library which must not be compiled in those ways.

manateelazycat commented 8 months ago

Can you help provide PR ? Thanks

phil-s commented 8 months ago

I cannot, as I don't know which elisp files are affected by the issue.

(I don't even understand the reason why elisp compilation is a problem for this project -- I'm not currently using lsp-bridge; I was just looking in passing, and the readme warning jumped out at me as being very odd given that "do not compile" is something that can be enforced.)

The change would simply be along these lines:

-    -*- lexical-binding: t; -*-
+    -*- lexical-binding: t; no-byte-compile: t; -*-

(I've just checked that no-native-compile is implicit when no-byte-compile is set, as native compilation depends upon byte-compilation.)