Auto-import broken for duplicate names

[runekaagaard]

When using pyright lsp server to auto-import a name that exists in multiple files only the last candidate is shown. This is due to the "detail" key of the response always being "Auto-import" and thus the candidate key being "MyThing_Auto-import" for all the candidates.

This little change in the process_response method in completion.py works for me:

import hashlib

if self.file_action.enable_auto_import:
    candidate["additionalTextEdits"] = item.get("additionalTextEdits", [])
    key += "_".join(
        hashlib.md5(x["newText"].encode('utf-8')).hexdigest()
        for x in candidate["additionalTextEdits"])
    candidate["key"] = key

[manateelazycat]

can you send test code to me?

[runekaagaard]

Sure, you can try to import the symbol MyThing in the file d.py from this repo:

https://github.com/runekaagaard/lspb-example

It should show MyThing from a.py, b.py and c.py.

[manateelazycat]

How to operate? Can you tell me the steps to reproduce?

[runekaagaard]

Sure, go to d.py and type MyThing on an empty line. I only shows the completion for one of a, b or c but should show all three.

[manateelazycat]

I typed MyThing, but there was no completion menu. Can you share your lsp-bridge configuration?

[runekaagaard]

Hmmm, that's very standard. You are probably missing pyright?

pip install pyright
# or
npm install -g pyright

[manateelazycat]

I guess because lsp-bridge-python-multi-lsp-server "pyright-background-analysis_ruff" ?

Which python lsp server did you use?

[runekaagaard]

I use pyright and have no special configuration related to that, LSPB picks it up automatically.

[manateelazycat]

Can you send a PR ? I'm happy merge it if logic is okay.

[runekaagaard]

https://github.com/manateelazycat/lsp-bridge/pull/829