search

manateelazycat / lsp-bridge

A blazingly fast LSP client for Emacs
GNU General Public License v3.0
1.42k stars 204 forks source link

Incorrect response to `window/workDoneProgress/create` #938

Closed mhanberg closed 4 months ago

mhanberg commented 4 months ago

https://github.com/manateelazycat/lsp-bridge/blob/b8768c4a76525d82360d124c829774acd26634c3/core/lspserver.py#L733

Unless it is responding with an error, the only valid response is null.

The code linked above seems to be responding with an empty object.

Also, if you don't support this request, you can declare the window.workDoneProgress client capability as false, then the server should not even request it (if it does, the server should be fixed).

knarkzel commented 4 months ago

Changing to this gets rid of error message for nextls:

self.sender.send_response(message["id"], None)
manateelazycat commented 4 months ago

https://github.com/manateelazycat/lsp-bridge/commit/c4b9ac3617ca8072ff77b1440b628e382188d6ff

Has fixed, thanks for report. ;)