Do not use format to create shell commands

manateelazycat / sdcv

Emacs interface for sdcv (Stardict console version)

73 stars 14 forks source link

Closed sirikid closed 2 years ago

sirikid commented 3 years ago

I don't use this package, I am just an Elisp hacker, whom @xFA25E asked to look at #20. This code is untested, btw.

sirikid commented 3 years ago

@pRot0ta1p @xFA25E

xFA25E commented 3 years ago

Thanks for looking into this! Gonna test this for you)

manateelazycat commented 3 years ago

What is the problem with this patch to solve? Why did this patch have changed so much?

sirikid commented 3 years ago

What is the problem with this patch to solve?

It replaces commands unsafe construction and inefficient parsing of theirs output.

Why did this patch have changed so much?

It didn't.

Also it is superseded by #26