search

manateelazycat / sdcv

Emacs interface for sdcv (Stardict console version)
73 stars 14 forks source link

Feature: customizable shell command #26

Closed xFA25E closed 2 years ago

xFA25E commented 3 years ago

This is the first version of custamizable shell command with a list.

@pRot0ta1p @sirikid

xFA25E commented 3 years ago

Thanks for the review!

manateelazycat commented 3 years ago

First, thanks for patch.

Please split the patch, each patch only do one thing, all the content is mixed together, I can't review.

I don't understand what is the purpose of custom shell command?

xFA25E commented 3 years ago

The purpose is to make sdcv shell command customizable

xFA25E commented 3 years ago

You are right, I should split the patch. I'll send a splitted version soon