manatools / dnfdaemon

DBus daemon for doing package action with the dnf package manager
GNU General Public License v2.0
12 stars 16 forks source link

WIP: support for DNF 3.0 #19

Closed edcuba closed 6 years ago

edcuba commented 7 years ago

Dnf 2.8 introduces unified software database which changes some non-API calls.

P.S. I have not tested it yet - it breaks unit tests.

Conan-Kudo commented 7 years ago

@edynox Thanks for this! Could you please get it into mergeable shape?

edcuba commented 7 years ago

@Conan-Kudo I have some trouble running unit tests (by make run-tests-unit). I am getting:

======================================================================
ERROR: Test the backend packages
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/dnfdaemon/test/test_common.py", line 155, in test_packages
    base = support.MockBase('main')
  File "/dnfdaemon/test/support.py", line 86, in __init__
    repo = MockRepo(r, None)
  File "/usr/lib/python3.6/site-packages/dnf/repo.py", line 514, in __init__
    super(Repo, self).__init__(section=name, parent=parent_conf)
  File "/usr/lib/python3.6/site-packages/dnf/conf/config.py", line 959, in __init__
    self._add_option('enabled', inherit(parent._get_option('enabled')))
AttributeError: 'NoneType' object has no attribute '_get_option'

I tried to rewrite test_support to Swdb compatible form, but it has to be tested first (and probably changed in other tests as well)...

Conan-Kudo commented 7 years ago

@edynox Looks like DNF broke more APIs... :/

dmach commented 6 years ago

Can you close this PR? I created PR#22 that fixes more issues.

Conan-Kudo commented 6 years ago

Sure.