search

manatools / dnfdaemon

DBus daemon for doing package action with the dnf package manager
GNU General Public License v2.0
12 stars 16 forks source link

Handle additional DNF transaction callback actions in DNF 3 #25

Closed AdamWill closed 6 years ago

AdamWill commented 6 years ago

See https://bugzilla.redhat.com/show_bug.cgi?id=1624652 and https://bugzilla.redhat.com/show_bug.cgi?id=1630113 . It seems that a change in DNF 3 causes transaction callbacks to use actions that aren't included in the callback API definition or docs. Because dnfdaemon/dnfdragora currently kinda assume they know all possible callback actions, this winds up causing dnfdragora to crash if it tries to handle a callback with one of these unknown actions.

This commit adds the extra actions to the const <-> string dict in dnfdaemon's TransactionProgress callback, so that in the dbus RPMProgress message it sends out, the action will be a string, as dnfdragora's handler for the message expects. A companion commit for dnfdragora will add handling for the new string values, and also make it not crash if an unexpected action shows up.

Signed-off-by: Adam Williamson awilliam@redhat.com

AdamWill commented 6 years ago

dnfdragora PR: https://github.com/manatools/dnfdragora/pull/116