search

manatools / dnfdaemon

DBus daemon for doing package action with the dnf package manager
GNU General Public License v2.0
12 stars 16 forks source link

HistoryUndo crashes #30

Open anaselli opened 4 years ago

anaselli commented 4 years ago

running dnfdragora history undo i got the following error:

File "/usr/lib64/python3.8/site-packages/dbus/service.py", line 711, in _message_cb
    retval = candidate_method(self, *args, **keywords)
  File "/usr/lib/python3.8/site-packages/dnfdaemon/server/__init__.py", line 68, in newFunc
    rc = func(*args, **kwargs)
  File "/usr/share/dnfdaemon/dnfdaemon-system", line 305, in HistoryUndo
    value = self.history_undo(tid)
  File "/usr/lib/python3.8/site-packages/dnfdaemon/server/__init__.py", line 656, in history_undo
    history = dnf.history.open_history(self.base.history)
AttributeError: module 'dnf.history' has no attribute 'open_history'
Conan-Kudo commented 4 years ago

@j-mracek, @dmach: Did this API get ripped out or something? I don't recall seeing something remove it...

j-mracek commented 4 years ago

I believe that the issue is from dnf-4.0.4. Sorry for that

Conan-Kudo commented 4 years ago

That was with DNF 4.2.6 in Mageia Cauldron... @anaselli, did the upgrade to DNF 4.2.17 fix this for you?

j-mracek commented 4 years ago

The problem is that there is no API for history available and never was. Also sorry for that.

Conan-Kudo commented 4 years ago

Oh, welp... So what do we do? We need an API to access history information...

j-mracek commented 4 years ago

Yes, we need it. This is bad situation and even worst timing. I will think about.